Patch / RFC: add "flashcp" applet

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Sat Nov 14 22:57:31 UTC 2009


On Sat, Nov 14, 2009 at 11:39:22PM +0100, Stefan Seyfried wrote:
>On Sat, 14 Nov 2009 23:05:02 +0100
>Bernhard Reutner-Fischer <rep.dot.nop at gmail.com> wrote:
>
>> On Sat, Nov 14, 2009 at 10:53:22PM +0100, Stefan Seyfried wrote:
>> >On Sat, 14 Nov 2009 22:15:14 +0100
>> >Tito <farmatito at tiscali.it> wrote:
>> >> PS.: progress() is used only in two sites, is it worth the hassle, couldn't it be inlined?
>> 
>> We have a progress-meter in libbb. You should really use that.
>
>Which makes the applet > 2000 bytes.

aha, well that's not good then ;(
>
>seife at strolchi:/local/seife/src/git-repos/busybox> scripts/bloat-o-meter /dev/shm/bb-wo-fcp/busybox_unstripped /dev/shm/bb/busybox_unstripped
>function                                             old     new   delta
>flashcp_main                                           -     678    +678
>bb_progress_update                                     -     504    +504
>.rodata                                            35558   35987    +429
>__udivdi3                                              -     282    +282
>packed_usage                                        1270    1393    +123
>bb_progress_init                                       -      29     +29
>xread                                                  -      28     +28
>monotonic_sec                                          -       9      +9
>applet_names                                         140     148      +8
>applet_main                                           76      80      +4
>applet_nameofs                                        38      40      +2
>------------------------------------------------------------------------------
>(add/remove: 6/0 grow/shrink: 5/0 up/down: 2096/0)           Total: 2096 bytes
>-- 
>Stefan Seyfried
>
>"Any ideas, John?"
>"Well, surrounding them's out."


More information about the busybox mailing list