[PATCH 3/3] mkfs_vfat: silence errors on BE platforms

Bastian Blank waldi at debian.org
Fri Nov 6 11:58:43 UTC 2009


On Fri, Nov 06, 2009 at 12:01:01PM +0100, Marc Kleine-Budde wrote:
> >>  #define STORE_LE(field, value) \
> >>  do { \
> >>  	if (sizeof(field) == 4) \
> >> -		field = cpu_to_le32(value); \
> >> +		field = (typeof(field))cpu_to_le32(value);	\
> > 
> > This looks wrong. If sizeof(field)==4, how can cpu_to_le32 not fit in
> > there? Doesn't cpu_to_le32() return a 32bit value?
> > 
> > Or am I missing something obviously? (quite possible ;)
> 
> cpu_to_le32 probably returns a 32bit value, but _always_.
> Even if "field" is just a 16bit value. Which leads to this warnings.

But "field" _is_ a 32bit value.

Bastian

-- 
Either one of us, by himself, is expendable.  Both of us are not.
		-- Kirk, "The Devil in the Dark", stardate 3196.1


More information about the busybox mailing list