[patch] busybox-1.14.1 ftpd: make -vv -S more useful

Stefan Seyfried seife at suse.de
Sun May 31 13:19:19 UTC 2009


It's actually a bad idea to log verbose output to stdout,
so if syslog is enabled, only use syslog.

This made debugging much easier for me ;)

diff -rup busybox-1.14.1/networking/ftpd.c busybox-1.14.1-fixed/networking//ftpd.c
--- busybox-1.14.1/networking/ftpd.c	2009-05-27 18:00:23.000000000 +0200
+++ busybox-1.14.1-fixed/networking//ftpd.c	2009-05-31 14:37:58.465454909 +0200
@@ -1142,7 +1142,7 @@ int ftpd_main(int argc UNUSED_PARAM, cha
 	if (opts & OPT_S) {
 		/* LOG_NDELAY is needed since we may chroot later */
 		openlog(applet_name, LOG_PID | LOG_NDELAY, LOG_DAEMON);
-		logmode |= LOGMODE_SYSLOG;
+		logmode = LOGMODE_SYSLOG;
 	}
 	if (logmode)
 		applet_name = xasprintf("%s[%u]", applet_name, (int)getpid());


Thanks,
    Stefan
-- 
Stefan Seyfried
R&D Team Mobile Devices            |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."

This footer brought to you by insane German lawmakers:
SUSE Linux Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-1.14.1-ftpd-syslog-fix.diff
Type: text/x-patch
Size: 580 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090531/cb21a8d6/attachment.bin>


More information about the busybox mailing list