[PATCH] fix the Sorcerer's Apprentice Syndrome in tftp (-g)

[Baruch Siach]

Hi Denys,

On Thu, May 14, 2009 at 05:18:03PM +0300, Baruch Siach wrote:
> Hi Denys,
> 
> On Sun, May 10, 2009 at 10:57:44PM +0200, Denys Vlasenko wrote:
> > Hmm. Doe it happen with _busybox_ TFTP server? It seems to contain the 
> > code
> > to prevent that.
> 
> I didn't try the Busybox tftp server. I did see this bug with the server of 
> netkit-tftp, and with tftpd-hpa.

I must correct myself. I see this bug in netkit-tftp and atftpd, not 
tftpd-hpa.

The netkit-tftp server has another relevant bug. It doesn't retransmit DATA 
packets on timeout. This may be the reason for the "fix" that I reverted.  If 
an ACK packet gets lost, the transfer just halts. I haven't seen this myself, 
but a college of mine has.

Apparently, the netkit-tftp server is broken, and there is no easy way to make 
the tftp client work with this server correctly in all circumstances. The 
decision of whether to keep my patch or not is yours, then.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -