bad print in hdparm.c

Denys Vlasenko vda.linux at googlemail.com
Wed May 20 12:49:22 UTC 2009


On Wed, May 20, 2009 at 11:11 AM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Wednesday 20 May 2009 04:53:00 Mikhail Gusarov wrote:
>> Twas brillig at 04:51:29 20.05.2009 UTC-04 when vapier at gentoo.org did gyre
> and gimble:
>>  >> >printf("%u minutes %u seconds", standby / 12, (standby*5) % 60);
>>  >>
>>  >> <printf("%u minutes %u seconds", standby / 12, standby % 12);
>>
>>  MF> better to write it as (60 / 5) so people dont get confused as to
>>  MF> where this magic 12 is coming from
>>
>> why not standby / (60 / 5) then? :)
>
> i would agree with that change as well

Fixed in git, thanks!
--
vda


More information about the busybox mailing list