bad print in hdparm.c

Mike Frysinger vapier at gentoo.org
Wed May 20 09:11:53 UTC 2009


On Wednesday 20 May 2009 04:53:00 Mikhail Gusarov wrote:
> Twas brillig at 04:51:29 20.05.2009 UTC-04 when vapier at gentoo.org did gyre 
and gimble:
>  >> >printf("%u minutes %u seconds", standby / 12, (standby*5) % 60);
>  >>
>  >> <printf("%u minutes %u seconds", standby / 12, standby % 12);
>
>  MF> better to write it as (60 / 5) so people dont get confused as to
>  MF> where this magic 12 is coming from
>
> why not standby / (60 / 5) then? :)

i would agree with that change as well
-mike


More information about the busybox mailing list