[patch] little fixes against Linux specific code

Denys Vlasenko vda.linux at googlemail.com
Tue May 19 11:22:54 UTC 2009


On Tue, May 19, 2009 at 1:10 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Tuesday 19 May 2009 06:44:29 Denys Vlasenko wrote:
>> On Sat, May 16, 2009 at 1:56 AM, Mike Frysinger <vapier at gentoo.org> wrote:
>> > please write your patches against git and use git to generate the log.
>>
>> Why? Is it some sort of a crusade to force everyone to use
>> version control software you like?
>>
>> I'm sure it isn't, but it may be interpreted as such.
>
> the more logical answer would be that the tools handle a lot of common
> mistakes for the user, and once the tool is learned, allows people to submit
> things much quicker and for us to merge things much quicker.
>
>> I think it's better to be more tolerant to the patch submitters.
>
> proper submission allows users to submit their changes from the command line
> -- where they already have to be in order to generate the diff/patch in the
> first place.
>
> proper submission allows committer (i.e. you):
>  - save file
>  - run 1 git command to import the entire thing

Makes sense.

I just don't want it to be a hard requirement that every patch
people send to ml must be produced by git. It can be
a recommended practice.

I applied patches with some edits. Thanks Luca.
--
vda


More information about the busybox mailing list