wrong modules.dep with 2.6 compressed modules (1.13.4/1.14.0)

Denys Vlasenko vda.linux at googlemail.com
Mon May 18 11:16:41 UTC 2009


On Mon, May 18, 2009 at 10:30 AM, Denys Vlasenko
<vda.linux at googlemail.com> wrote:
> On Sun, May 17, 2009 at 12:45 PM, Gilles Espinasse <g.esp at free.fr> wrote:
>> I try to use compressed modules because it is simplier when out of initramfs
>> modules are compressed and it minimize memory requirement on install when
>> modules are on tmpfs.
>>
>> Then I find that modules.dep miss many dependencies with compressed modules.
>> Tested on x86 only.
> ...
>> This was produced with busybox-1.13.4 using a find to gzip/ungzip modules.
>> find /lib/modules/$(KVER)/kernel -name '*.ko.gz' -a -type f | xargs gzip -d
>> or
>> find /lib/modules/$(KVER)/kernel -name '*.ko' -a -type f | xargs gzip -9
>>
>> I try to compare with modules.dep result produced by modules-init-tools-3.8
>> but dependencies are in a different order (reverse?) in the same line.
>> So hard to read the diff.
>
> I post-process depmod output like this:
>
> [./busybox] depmod -n | ./depmod_process.sh | sort >OUTFILE
>
> where ./depmod_process.sh is:
>
> while read -r word rest; do
>    if ! test "${word/*:/}"; then
>        echo -n "$word "
>        echo "$rest" | xargs -n1 | sort | xargs
>    else
>        echo "$word $rest";
>    fi
> done
>
> The diffs of OUTFILEs are way smaller.
> I see a few (harmless) differences between bbox and module-init-tools 3.4,
> going to fix them now.
>
> Did not try "depmod -n"-ing with compressed modules yet.

One bug in depmod and one bug in gzip (!). :( :( :(

Please try these 3 patches (apply them in sequence to 1.14.0).
--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 6.patch
Type: text/x-patch
Size: 3605 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090518/8dbdfcd7/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 7.patch
Type: text/x-patch
Size: 1367 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090518/8dbdfcd7/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8.patch
Type: text/x-patch
Size: 3249 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090518/8dbdfcd7/attachment-0002.bin>


More information about the busybox mailing list