[PATCH] make system uid/gid range configurable

Denys Vlasenko vda.linux at googlemail.com
Mon May 11 01:14:50 UTC 2009


On Tuesday 05 May 2009 23:22, Tito wrote:
> Hi,
> this patch makes FIRST_SYSTEM_UID, LAST_SYSTEM_UID, FIRST_SYSTEM_GID, LAST_SYSTEM_GID
> used by adduser and addgroup --system configurable to allow different values
> for exotic systems like the Android Dev 1 Phone.
> The patch was tested a little for the Config part and compile tested for adduser and addgroup.
> The Config system gurus maybe could take a look at the relevant Config part as
> i did it by intuition ;-) (was not able to find docs about it....).
> 
> Ciao,
> TIto
> 
> --- busybox.orig/loginutils/Config.in	2009-04-23 14:54:09.000000000 +0200
> +++ busybox/loginutils/Config.in	2009-05-05 21:51:15.000000000 +0200
> @@ -152,6 +152,22 @@
>  	help
>  	  Support long options for the adduser applet.
>  
> +config FIRST_SYSTEM_ID
> +	int "First valid system uid or gid for adduser and addgroup"
> +	depends on ADDUSER || ADDGROUP
> +	range 0 LAST_SYSTEM_ID
> +	default 100
> +	help
> +	  First valid system uid or gid for adduser and addgroup
> +
> +config LAST_SYSTEM_ID
> +	int "Last  valid system uid or gid for adduser and addgroup"
> +	depends on ADDUSER || ADDGROUP
> +	range FIRST_SYSTEM_ID 64999
> +	default 999
> +	help
> +	  Last valid system uid or gid for adduser and addgroup

I propose having just FIRST_SYSTEM_ID. What is the rationale for
having configurable LAST_SYSTEM_ID? I don't see any.

Care to re-do the patch?
--
vda


More information about the busybox mailing list