Why #if ENABLE_xxx isn't as evil as Rob thinks

[Mike Frysinger]

On Saturday 28 March 2009 09:56:20 Denys Vlasenko wrote:
> Line 4336:
>
>         if (!ENABLE_FEATURE_SH_EXTRA_QUIET && G.interactive_fd) {
>                 printf("\n\n%s hush - the humble shell v"HUSH_VER_STR"\n",
> bb_banner); printf("Enter 'help' for a list of built-in commands.\n\n"); }
>
>
> shell/hush.c: In function 'hush_main':
> shell/hush.c:4336: error: 'struct globals' has no member named
> 'interactive_fd' make[1]: *** [shell/hush.o] Error 1
> make: *** [shell] Error 2

actually, this error has nothing to do with my previous CPP #if to C if 
change.  i was fixing the case where the help text is not shown if jobs 
support is disabled, but in doing so, moved some code out where interactive_fd 
is not available.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090328/b8c09333/attachment.pgp>