Why #if ENABLE_xxx isn't as evil as Rob thinks

Mike Frysinger vapier at gentoo.org
Sat Mar 28 14:02:15 UTC 2009


On Saturday 28 March 2009 09:56:20 Denys Vlasenko wrote:
> Line 4336:
>
>         if (!ENABLE_FEATURE_SH_EXTRA_QUIET && G.interactive_fd) {
>                 printf("\n\n%s hush - the humble shell v"HUSH_VER_STR"\n",
> bb_banner); printf("Enter 'help' for a list of built-in commands.\n\n"); }
>
>
> shell/hush.c: In function 'hush_main':
> shell/hush.c:4336: error: 'struct globals' has no member named
> 'interactive_fd' make[1]: *** [shell/hush.o] Error 1
> make: *** [shell] Error 2

i dont think #if is completely evil.  i tried to make the change only when it 
wouldnt break things, but i guess i missed one.

> Also, please "cd shell/hush_test; ./run-all"
> after you hack on hush. Shells are fragile beasts, need to be
> extra paranoid when touch them.

i'm cross-compiling the shell here ... wonder if this will work on the board
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090328/fb164352/attachment.pgp>


More information about the busybox mailing list