[PATCH 2/2] blkid: add all known fs-types for output

Denys Vlasenko vda.linux at googlemail.com
Thu Jun 18 21:03:39 UTC 2009


Sorry for the delay with the code review....


On Saturday 30 May 2009 13:21, Hans Ulli Kroll wrote:
> Signed-off-by: Hans Ulli Kroll <elektroman at nas-portal.org>
> ---
>  util-linux/volume_id/cramfs.c             |    2 +-
>  util-linux/volume_id/ext.c                |    8 ++++----
>  util-linux/volume_id/fat.c                |    2 +-
>  util-linux/volume_id/hfs.c                |    4 ++--
>  util-linux/volume_id/iso9660.c            |    2 +-
>  util-linux/volume_id/jfs.c                |    2 +-
>  util-linux/volume_id/linux_raid.c         |    2 +-
>  util-linux/volume_id/linux_swap.c         |    2 +-
>  util-linux/volume_id/luks.c               |    2 +-
>  util-linux/volume_id/ntfs.c               |    2 +-
>  util-linux/volume_id/ocfs2.c              |    2 +-
>  util-linux/volume_id/reiserfs.c           |   16 ++++++++++------
>  util-linux/volume_id/romfs.c              |    2 +-
>  util-linux/volume_id/udf.c                |    2 +-
>  util-linux/volume_id/volume_id_internal.h |    2 +-
>  util-linux/volume_id/xfs.c                |    4 ++--
>  16 files changed, 30 insertions(+), 26 deletions(-)
> 
> diff --git a/util-linux/volume_id/cramfs.c b/util-linux/volume_id/cramfs.c
> index dd939e4..87ba9bb 100644
> --- a/util-linux/volume_id/cramfs.c
> +++ b/util-linux/volume_id/cramfs.c
> @@ -51,7 +51,7 @@ int volume_id_probe_cramfs(struct volume_id *id /*,uint64_t off*/)
>  		volume_id_set_label_string(id, cs->name, 16);
>  
>  //		volume_id_set_usage(id, VOLUME_ID_FILESYSTEM);
> -//		id->type = "cramfs";
> +		strcpy (id->type_version, "cramfs");

Looks like type_version always points to a constant string.
Then it's better to not copy it, but merely remember a pointer,
as old code was doing.
--
vda


More information about the busybox mailing list