[PATCH] fsync applet

Alexander Shishkin virtuoso at slind.org
Wed Jun 17 21:47:03 UTC 2009


2009/6/18 Rob Landley <rob at landley.net>:
> On Friday 12 June 2009 11:16:55 Alexander Shishkin wrote:
>> 2009/6/12 Denys Vlasenko <vda.linux at googlemail.com>:
>> > On Thu, Jun 11, 2009 at 1:07 PM, <virtuoso at slind.org> wrote:
>> >> From: Pekka Pessi <Pekka.Pessi at nokia.com>
>> >>
>> >> Issue fsync() system call on a file to ensure its buffers are
>> >> synchronized with the backing storage.
>> >>
>> >> Signed-off-by: Alexander Shishkin <virtuoso at slind.org>
>> >
>> > Please use CONFIG_WERROR. With CONFIG_WERROR=y:
>> >
>> >  CC      coreutils/fsync.o
>> > cc1: warnings being treated as errors
>> > coreutils/fsync.c: In function 'fsync_main':
>> > coreutils/fsync.c:15: error: unused parameter 'argc'
>> > make[1]: *** [coreutils/fsync.o] Error 1
>> >
>> > I can fix it on my end and commit.
>>
>> I'll be right on it, no problem. Thanks for the catch.
>>
>> > What about other concern - "applet creep"?
>> >
>> > I googled for it and it seems there is no such program on Linux yet.
>>
>> Walter suggests otherwise, but I indeed do not know of such a tool in
>> linux. There might well be need for it and it might eventually show up
>> somewhere around, say, mtd-tools.
>
> I note that readlink started life as a debian-only command, and busybox has
> had that for years.  (I have no idea how long because the source control
> repository has degraded severely in the past few years.  If you do a "git log
> coreutils/readlink.c" it says the file was moved in 2007 and the history before
> that was apparently lost.  Yes, even with git log -M.  I'm pretty sure this
> one was there in 2003, but am not downloading old source tarballs to confirm
> it.)

---cut---
commit 872138de50b1c5bbf105b0243f5778fcb02b310b
Author: Mark Whitley <markw at lineo.com>
Date:   Mon Oct 9 18:56:47 2000 +0000

    Added cmp and readlink applets from Matt Kraai.
---cut---

Thanks for the heads up, I'll get back to this once I recover from the
sleep deprivation that I currently suffer from.

Regards,
--
Alex


More information about the busybox mailing list