[PATCH] Fix modprobe status reported v2

[Gilles Espinasse]

----- Original Message ----- 
From: "Denys Vlasenko" <vda.linux at googlemail.com>
To: "Gilles Espinasse" <g.esp at free.fr>
Cc: <busybox at busybox.net>
Sent: Sunday, June 07, 2009 4:27 PM
Subject: Re: [PATCH] Fix modprobe status reported v2


>> function old new delta
>> modprobe_main 463 533 +70
>> do_modprobe 266 277 +11
>> add_probe 81 80 -1
>> -------------------------------------------------------------------------
-----
>> (add/remove: 0/0 grow/shrink: 2/1 up/down: 81/-1) Total: 80 bytes
>> text data bss dec hex filename
>> 221388 1585 8752 231725 3892d busybox_old
>> 221468 1585 8752 231805 3897d busybox_unstripped
>>
> Sorry, there were changes to modprobe recently, and now patch doe s not
apply.
> Can you rediff it please?
>
Patch was against 1_14_stable branch.
Do you want patch against master or 1.14_stable or both?

>> - /* bool. "Did we have 'symbol:FOO' requested on cmdline?" */
>> - smallint need_symbols;
>> + /* 1 "Did we have 'symbol:FOO' requested on cmdline?"
>> + * 2 modprobe status */
>> + smallint modprobe_flags;
>
> Try using two separate variables. It may turn out to result
> in smaller code.
>
Should be true

function                                             old     new   delta
modprobe_main                                        484     539     +55
do_modprobe                                          266     277     +11
----------------------------------------------------------------------------
--
(add/remove: 0/0 grow/shrink: 2/0 up/down: 66/0)               Total: 66
bytes
   text    data     bss     dec     hex filename
 221223    1585    8752  231560   38888 busybox_old
 221289    1585    8752  231626   388ca busybox_unstripped

Will resend once I know wich base to use.

    Gilles