[patch] Makefile, small

[Cristian Ionescu-Idbohrn]

On Mon, 26 Jan 2009, Rob Landley wrote:

> On Saturday 24 January 2009 08:06:02 Cristian Ionescu-Idbohrn wrote:
> > Emacs does not grok quotes in makefile subs very well, and screws up
> > colorized code :(
> > Similar to the CONFIG_EXTRA_CFLAGS, please accept this patch:
> >
> > --- busybox/Makefile	(revision 23984)
> > +++ busybox/Makefile	(working copy)
> > @@ -168,6 +168,7 @@
> >  CROSS_COMPILE := $(shell grep ^CONFIG_CROSS_COMPILER_PREFIX .config
> > 2>/dev/null) CROSS_COMPILE := $(subst
> > CONFIG_CROSS_COMPILER_PREFIX=,,$(CROSS_COMPILE)) CROSS_COMPILE := $(subst
> > ",,$(CROSS_COMPILE))
> > +#")
> >  endif
>
> Do we really want to pollute the code with unexplained workarounds for
> purely cosmetic bugs in a text editor many of us don't use?

Many of _who_?
Did you have a bad day?
Shall we start another flame war and/or text editor investigation?

There's at least one "polluting" "unexplained workaround" already:

Makefile.flags:87:ifneq ($(CONFIG_EXTRA_CFLAGS),)
Makefile.flags:88:CFLAGS += $(strip $(subst ",,$(CONFIG_EXTRA_CFLAGS)))
Makefile.flags:89:#"))
Makefile.flags:90:endif

It's not important.

> Did you at least poke the emacs guys and ask them to fix their obvious
> bug?

It used to be worth.

> (Parsing complexity aside, I don't believe quotes span multiple lines in
> make, so the highlighting should have stopped at the end of line
> anyway.)

I actually found one :)  Makefile, lines 1194-1201:

define cmd_tags
	rm -f $@; \
	CTAGSF=`ctags --version | grep -i exuberant >/dev/null &&     \
                echo "-I __initdata,__exitdata,__acquires,__releases  \
                      -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL              \
                      --extra=+f --c-kinds=+px"`;                     \
                $(all-sources) | xargs ctags $$CTAGSF -a
endef

Let's just forget about all that.


Cheers,

-- 
Cristian