reworked login.c

Rob Landley rob at landley.net
Thu Jan 22 19:11:04 UTC 2009


On Tuesday 20 January 2009 12:19:55 walter harms wrote:
> Denys Vlasenko schrieb:
> > -       short_tty = full_tty;
> > -       username[0] = '\0';
> > +       USE_SELINUX(security_context_t user_sid = NULL;
> > +               )
> > +               USE_FEATURE_UTMP(struct utmp utent;
> > +
> > +               )
>
> yep, i did not notice.
> since the USE_SELINUX macro has no ";" indent fails to see the eol and gets
> confused. if it works it is nice since it removes the whole #ifdef forest

I note that ";" by itself is a valid NOP statement, so technically:

USE_SELINUX(security_context_t user_sid = NULL);

Should compile just fine, as long as you haven't got if() levels and such to 
worry about.  (It's very slightly wrong, but less ugly.)



More information about the busybox mailing list