compile error in trunk -- selinux, loginutils/login.c

[walter harms]

i fear that come with one of my patches ...
i will fix it soon as i am back home.

thx for reporting.

re,
 wh


Robert P. J. Day schrieb:
> ...
> loginutils/login.c: In function ‘initselinux’:
> loginutils/login.c:184: error: passing argument 1 of
> ‘security_compute_relabel’ from incompatible pointer type
> make[1]: *** [loginutils/login.o] Error 1
> make: *** [loginutils] Error 2
> ...
> 
>   the problem?  here's loginutils/login.c:
> 
> static void initselinux(char *username, char *full_tty,
>                         security_context_t *user_sid)
> {
>     security_context_t old_tty_sid, new_tty_sid;
> 
>    ...
> 
>     if (security_compute_relabel(user_sid, old_tty_sid,
>                 SECCLASS_CHR_FILE, &new_tty_sid) != 0) {
>         bb_perror_msg_and_die("security_change_sid(%s) failed", full_tty);
>    ...
> 
> 
>   as you can see, the first arg to security_computer_relabel is a
> *pointer* to a security_context_t, but that routine is defined in
> selinux as:
> 
> int security_compute_relabel(security_context_t scon,
> security_context_t tcon, security_class_t tclass, security_context_t
> *newcon);
> 
>   that is, accepting a security_context_t (not a pointer to one).  or
> am i misreading this?
> 
> rday
> --
> 
> 
> ========================================================================
> Robert P. J. Day
> Linux Consulting, Training and Annoying Kernel Pedantry:
>     Have classroom, will lecture.
> 
> http://crashcourse.ca                          Waterloo, Ontario, CANADA
> ========================================================================
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox