[patch v2] Add flash_eraseall from mtd-utils

Alex Landau landau_alex at yahoo.com
Sun Feb 22 07:55:45 UTC 2009


----- Original Message ----

> From: Bernhard Reutner-Fischer <rep.dot.nop at gmail.com>
> To: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> Cc: busybox at busybox.net
> Sent: Wednesday, February 18, 2009 3:29:50 PM
> Subject: Re: [patch v2] Add flash_eraseall from mtd-utils
> 
> On Tue, Feb 17, 2009 at 11:03:28PM +0100, Sebastian Andrzej Siewior wrote:
> >This is the result after converting mtd-utils' flash_eraseall to BB.
> 
> Applied as r25355 and shrank by ca. 110 bytes in r25356, thanks.
> _______________________________________________
> busybox mailing list
> busybox at busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox

Hi,

Not compiled or tested it, but from reading the code it seems that r25356
broke one thing. On line 145 (looking at r25376) it's written flags = ~BBTEST, while
as far as I can tell, the original version r25355 intended  flags &= ~BBTEST.
The regression breaks erasing NOR flashes.

Regards,
Alex



      



More information about the busybox mailing list