fbsplash breakage by 25333

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Mon Feb 16 14:08:18 UTC 2009


On Mon, Feb 16, 2009 at 01:50:21PM +0100, Denys Vlasenko wrote:
>On Mon, Feb 16, 2009 at 1:39 PM, Bernhard Reutner-Fischer

>>>I have an example splash.ppm file hre, and its header looks like this:
>>>
>>>P6
>>># CREATOR: The GIMP's PNM Filter Version 1.0
>>>640 480
>>>255
>>>[binary data starts here]
>>>
>>>The above change broke it.
>>
>> Fair enough, i wasn't aware that there can be comments.
>> Apparently even this would be a legal header:
>> ---8<---
>> P6
>> 640 #something
>> 480 #another comment
>> # comment
>> 255
>> ---8<---
>>
>> r25342 should deal with this fine (untested).
>
>Oh no, please don't, I'm working on it right now;

ouch, sorry too late, i've already checked it in :-/

>also trying to add that text rendering.

btw, fbset seems to be completely broken, i can't set -depth ?
Attached hunk would cure it for me, i'll let you deal with it
since you apparently touched fbset alot in the past, ok?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fbset-does-not-set-depth.patch
Type: text/x-diff
Size: 3147 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090216/14a5dba7/attachment.bin>


More information about the busybox mailing list