applets wish: beep and sfdisk

Denys Vlasenko vda.linux at googlemail.com
Sat Aug 22 13:46:41 UTC 2009


On Friday 21 August 2009 11:21, Bernhard Reutner-Fischer wrote:
> On Wed, Aug 19, 2009 at 11:46:26PM +0200, Bernhard Reutner-Fischer wrote:
> >On Wed, Aug 19, 2009 at 12:12:17PM -0700, Nathan Angelacos wrote:
> 
> updated full patch is attached (which also handles 'beep -d' like it
> should)

Is there some quirk in command line format which prevents usage
of getopt()?

                while (rep) {
                        ioctl_arg = (int)(CLOCK_TICK_RATE/freq);
                        xioctl(speaker, KIOCSOUND, (void*)ioctl_arg);
                        usleep(1000 * length);
                        ioctl(speaker, KIOCSOUND, 0);
                        if (rep--)
                                usleep(delay);
                }

"if (rep--)" is always true. did you mean "if (--rep)"?

I propose the following two patches.

function                                             old     new   delta
beep_main                                            394     269    -125

--
vda
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1.patch
Type: text/x-diff
Size: 2837 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090822/46e9883f/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2.patch
Type: text/x-diff
Size: 2445 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090822/46e9883f/attachment-0001.bin>


More information about the busybox mailing list