[PATCH] hush.c - export -n flag support

Mike Frysinger vapier at gentoo.org
Mon Apr 20 23:06:00 UTC 2009


On Monday 20 April 2009 18:05:09 Denys Vlasenko wrote:
> On Monday 20 April 2009 21:11, Bayram Kurumahmut wrote:
> > Added two new files: shell/hush_test/export-n.tests and
> > shell/hush_test/export-n.right
> > Added set then export -n test and test cases from my first mail
> > Config.in help text changed
>
> Problems:
>
> Did you try to build with HUSH_EXPORT_N off?
> It still accepts -n even then.

this is unrelated to his code.  not throwing an error with unknown option is 
not the same thing as accepting it.  we should add logic that rejects all 
unknown options.  that would result in -n being rejected by common code when 
support is turned off.

so, ignoring his patch completely, current code does not throw errors when 
doing things like:
export -n
export -Z
export -askdlfjasklfjasklf
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090420/2dfa8ef2/attachment.pgp>


More information about the busybox mailing list