[PATCH] hush.c - export -n flag support

Mike Frysinger vapier at gentoo.org
Mon Apr 20 05:46:16 UTC 2009


On Sunday 19 April 2009 15:12:55 Bayram Kurumahmut wrote:
> Add support for export '-n' flag

not in POSIX, thus it should have a config option and be disabled by default:
http://www.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#export

> Tested as the followings

so please create a test case in the hush test subdir

> # export -n A=1

i'm pretty sure your implementation handles this incorrectly.  this:
unset A; export -n A=1
should result in A being set to "1".  yours does not do this from what i can 
see.  by fixing that, you should be able to combine the ugly memory management 
your change addes with the existing xstrdup() in the code.

you've also got whitespace damage and useless comments (pretty much every one 
i saw was unnecessary).  
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090420/5b24a0b3/attachment.pgp>


More information about the busybox mailing list