problems with modprobe on kernel 2.4

Guenter lists at gknw.net
Mon Apr 6 00:01:59 UTC 2009


Hi,
Denys Vlasenko schrieb:
> On Thursday 02 April 2009 00:50, Guenter wrote:
>> Hi Denys,
>> Guenter schrieb:
>> but while reading through the code here some other observasions/questions:
>>
>>     uname(&uts);
>> is called always directly at beginning although the uts struct is only
>> used within '#if ENABLE_FEATURE_INSMOD_VERSION_CHECKING/#endif' --
>> shouldnt we move it just inside the #if block?
>>
>> I think same applies to m_has_modinfo too:
>>     m_has_modinfo = (get_modinfo_value(f, "kernel_version") != NULL);
>> is just before the #if block where it is used...
>>
>> if the feature ENABLE_FEATURE_INSMOD_VERSION_CHECKING is disabled then
>> these calls are wasted cpu cycles...
> 
> Feel free to send a patch which fixes this.
ok, here's the follow-up patch against recent svn - attached.

greetz, Guen.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: modutils-24.diff-4
URL: <http://lists.busybox.net/pipermail/busybox/attachments/20090406/6fdf3df3/attachment.diff>


More information about the busybox mailing list