r23407 broke dpkg

Denys Vlasenko vda.linux at googlemail.com
Wed Oct 15 14:32:37 UTC 2008


On Wednesday 15 October 2008 04:00:27 pm Peter Korsgaard wrote:
> Hi Denys,
> 
> Your r23407 (the FEATURE_SEAMLESS_* stuff) unfortunately doesn't work
> that nicely with dpkg / dpkg-deb.
> 
> Standard .deb files have data and control in .tar.gz, but
> FEATURE_SEAMLESS_GZ defaults to off, so in the default configuration
> stuff doesn't work. We unfortunately cannot just add 'default y if DPKG
> || DPKG_DEB' to FEATURE_SEAMLESS_GZ, as that option is always available,
> and hence the default value gets applied before the user has a chance
> to select dpkg.
> 
> I see 2 options:
> 
> Either we add a 'select FEATURE_SEAMLESS_GZ' to DPKG and DPKG_DEB,
> or we reintroduce dummy FEATURE_DEB_TAR_* config variables which
> depends on DPKG || DPKG_DEB and select the corresponding
> FEATURE_SEAMLESS_* option if enabled.
> 
> The first option isn't that nice as you then cannot disable gz support
> in dpkg, but the other option also isn't that pretty.
> 
> What do you say?

I think first one is ok. since dpks must have it, why not?
--
vda

diff -d -urpN busybox.5/archival/Config.in busybox.6/archival/Config.in
--- busybox.5/archival/Config.in	2008-09-28 17:02:08.000000000 +0200
+++ busybox.6/archival/Config.in	2008-10-15 16:29:24.000000000 +0200
@@ -113,6 +113,7 @@ config FEATURE_CPIO_O
 config DPKG
 	bool "dpkg"
 	default n
+	select FEATURE_SEAMLESS_GZ
 	help
 	  dpkg is a medium-level tool to install, build, remove and manage
 	  Debian packages.
@@ -123,9 +124,9 @@ config DPKG
 config DPKG_DEB
 	bool "dpkg_deb"
 	default n
+	select FEATURE_SEAMLESS_GZ
 	help
-	  dpkg-deb packs, unpacks and provides information about Debian
-	  archives.
+	  dpkg-deb unpacks and provides information about Debian archives.
 
 	  This implementation of dpkg-deb cannot pack archives.
 
 





More information about the busybox mailing list