[PATCH] invalid lseek when determining uuid of (possibly corrupt) fat

Clemens Helfmeier clemensh at cs.tu-berlin.de
Sat Nov 29 19:35:20 UTC 2008


Hi Denys,

I just tested 1.13.1 and it works fine so far.
But why did you use a constant for the upper boundary?

> #define FAT32_MAX                       0x0ffffff6
>   if (next_cluster < 2 || next_cluster > FAT32_MAX)

I think that can still result in the same behaviour when the next_cluster 
points to a cluster between the actual size of the partition and FAT32_MAX.

Thanks,
 Clemens

On Sat, Nov 29, 2008 at 04:44:12PM +0100, Denys Vlasenko wrote:
> On Friday 28 November 2008 15:37, Clemens Helfmeier wrote:
> > Hi people,
> > 
> > what do you think about this fat/uuid issue?
> > It would be great if you could maybe tell me if you ever experienced such 
> > things.
> 
> I forgot to reply to you original mail.
> I believe it is now fixed, thanks to your report.
> Can you test 1.13.1?
> --
> vda



More information about the busybox mailing list