busybox-1.12.1=>1.12.2 ash regression

[Gilles Espinasse]

----- Original Message ----- 
From: "Denys Vlasenko" <vda.linux at googlemail.com>
To: <busybox at busybox.net>
Cc: "Gilles Espinasse" <g.esp at free.fr>
Sent: Monday, November 24, 2008 11:55 PM
Subject: Re: busybox-1.12.1=>1.12.2 ash regression


> On Monday 24 November 2008 15:55, Gilles Espinasse wrote:
> > Just upgrading to busybox1.12.2 our installer, the first newt screen has
> > some border characters instead of the usual lines. Second or later
screens
> > have normal appearance.
> >
> > tty1 and other tty configuration is made in inittab with
> > tty1::respawn:/bin/iowrap /dev/tty1 /bin/ash --login -c /bin/installer
> >
> > If the ash change from 1.12.1 to 1.12.2 is reversed, first screen border
> > lines are normal again.
> >
> > Gilles
> >
> > For reference, here is the patch that I revert
>
> >  #if ENABLE_FEATURE_SH_STANDALONE
> >   if (applet_no >= 0) {
> > -  if (APPLET_IS_NOEXEC(applet_no))
> > +  if (APPLET_IS_NOEXEC(applet_no)) {
> > +   while (*envp)
> > +    putenv(*envp++);
> >     run_applet_no_and_exit(applet_no, argv);
> > +  }
> >    /* re-exec ourselves with the new arguments */
>
>
> Can you try just replacing
>
>    while (*envp)
>         putenv(*envp++);
>
> with
>
>    environ = envp;
>
> Does this work?

I will try.
In fact I find that reverting this patch not always work.
There is probably a race that is only win in approximately 30% of the boot.
I will do more testing.

Thank
    Gilles