busybox-1.12.1=>1.12.2 ash regression

[Gilles Espinasse]

Hello

Just upgrading to busybox1.12.2 our installer, the first newt screen has
some border characters instead of the usual lines. Second or later screens
have normal appearance.

tty1 and other tty configuration is made in inittab with
tty1::respawn:/bin/iowrap /dev/tty1 /bin/ash --login -c /bin/installer

If the ash change from 1.12.1 to 1.12.2 is reversed, first screen border
lines are normal again.

Gilles

For reference, here is the patch that I revert
diff -Nur busybox-1.12.1/shell/ash.c busybox-1.12.2/shell/ash.c
--- busybox-1.12.1/shell/ash.c 2008-09-28 20:04:18.000000000 +0200
+++ busybox-1.12.2/shell/ash.c 2008-11-09 18:20:37.000000000 +0100
@@ -6964,8 +6964,11 @@

 #if ENABLE_FEATURE_SH_STANDALONE
  if (applet_no >= 0) {
-  if (APPLET_IS_NOEXEC(applet_no))
+  if (APPLET_IS_NOEXEC(applet_no)) {
+   while (*envp)
+    putenv(*envp++);
    run_applet_no_and_exit(applet_no, argv);
+  }
   /* re-exec ourselves with the new arguments */
   execve(bb_busybox_exec_path, argv, envp);
   /* If they called chroot or otherwise made the binary no longer
@@ -12014,7 +12017,7 @@
  char *name;
  const char *p;
  char **aptr;
- int flag = argv[0][0] == 'r'? VREADONLY : VEXPORT;
+ int flag = argv[0][0] == 'r' ? VREADONLY : VEXPORT;

  if (nextopt("p") != 'p') {
   aptr = argptr;