dpkg version comparison bug
Denys Vlasenko
vda.linux at googlemail.com
Thu Nov 20 00:01:46 UTC 2008
On Wednesday 19 November 2008 22:54, Eugene T. Bordenkircher wrote:
> Hello all,
>
> Below, you'll find a patch against the current SVN head to fix a couple of bugs
> in the version comparison code for dpkg. As a brief explanation: (1) the old
> code did not handle epochs that were greater than a single digit, and (2) it
> did not compare alpha() portions of the version string correctly, most notably
> portions that included ~'s and other punctuation.
>
> You'll notice that the solution is almost a mirror image of the official code
> in dpkg. I looked at it and couldn't think of any better way than that to do
> the comparison. I added the copyright information at the top to make it official.
>
> So it correctly compares versions now and probably more importantly to some:
>
> text data bss dec hex filename
> 688420 2168 9388 699976 aae48 busybox.orig/busybox
> 688273 2168 9388 699829 aadb5 busybox.new/busybox
>
> Enjoy, and let me know if there is anything I missed or need to do a bit
> differently.
Patch appears to be corrupted:
# patch -p1 </tmp/dpkg_version_comparison.diff --dry-run
patching file archival/dpkg.c
Hunk #1 FAILED at 6.
Hunk #2 FAILED at 32.
Hunk #3 FAILED at 189.
Hunk #4 FAILED at 237.
Hunk #5 FAILED at 263.
5 out of 5 hunks FAILED -- saving rejects to file archival/dpkg.c.rej
Please resend as an attachment instead of cut-n-paste.
--
vda
More information about the busybox
mailing list