1.13.0 coreutils/id.c calls libc getgrouplist()

Denys Vlasenko vda.linux at googlemail.com
Mon Nov 17 00:12:35 UTC 2008


On Monday 17 November 2008 00:51, Hamish Moffatt wrote:
> On Sun, Nov 16, 2008 at 04:04:06PM +0100, Denys Vlasenko wrote:
> > On Sunday 16 November 2008 09:18, Tito wrote:
> > > On Sunday 16 November 2008 04:21:10 Denys Vlasenko wrote:
> > > Maybe we can add some warning like:
> > > 
> > > #if defined (__UCLIBC__) \
> > > && (__UCLIBC_MAJOR__ == 0 && __UCLIBC_MINOR__ < 9) \
> > > || (__UCLIBC_MINOR__ == 9 &&  __UCLIBC_SUBLEVEL__ < 30)
> > > #warning "Sorry, you need at least uClibc version 0.9.30 for getgrouplist :("
> > > #endif
> > > 
> > > Attached you will find a patch with the above check,
> > > please apply if you like it.
> > > The patch is only roughly tested as i don't use uClibc 
> > > (but seems to work as expected).
> > 
> > Applied and tested it to work as intended with 0.9.29 and 0.9.30.
> > Thanks!
> 
> Shouldn't it check that !defined(CONFIG_USE_BB_PWD_GRP) though? id works
> if that is enabled.

Fixed, thanks for noticing.
--
vda



More information about the busybox mailing list