latest bloat-o-meter change introduced some regression

Bernhard Fischer rep.dot.nop at gmail.com
Wed May 21 21:19:34 UTC 2008


On Wed, May 21, 2008 at 11:07:35PM +0200, Cristian Ionescu-Idbohrn wrote:
>If I back this patch:
>
>Index: scripts/bloat-o-meter
>===================================================================
>--- scripts/bloat-o-meter	(revision 22041)
>+++ scripts/bloat-o-meter	(working copy)
>@@ -21,12 +21,6 @@
> def getsizes(file):
>     sym = {}
>     for l in os.popen("nm --size-sort " + file).readlines():
>-        l = l.strip()
>-	# Skip empty lines
>-        if not len(l): continue
>-	# Skip archive members
>-        if len(l.split()) == 1 and l.endswith(':'):
>-          continue
>         size, type, name = l[:-1].split()
>         if type in "tTdDbBrR":
>             if "." in name: name = "static." + name.split(".")[0]
>
>I get real "function" names listed:
>
>function                                             old     new   delta
>last_main                                            448    1028    +580
>show_entry                                             -     342    +342
>.rodata                                           120946  121080    +134
>add_entry                                              -      45     +45
>packed_usage                                       17924   17956     +32
>static.ret                                             -       8      +8
>static.pos                                             -       8      +8
>start_time                                             -       4      +4
>list                                                 348     352      +4
>boot_down                                              -       1      +1
>
>instead of chopped (off by one) ones:
>
>function                                             old     new   delta
>last_mai                                             448    1028    +580

funny. Seems to come from:
	size, type, name = l[:-1].split()

No idea why the name is truncated on purpose.. *shrug*
I've dropped the strip and now that -1 doesn't strip off our
funcname[last] but again the \n or such, i assume. Pfff.

please svn up and thanks for the hint
>show_entr                                              -     342    +342
>.rodata                                           120946  121080    +134
>add_entr                                               -      45     +45
>packed_usag                                        17924   17956     +32
>static.ret                                             -       8      +8
>static.pos                                             -       8      +8
>start_tim                                              -       4      +4
>lis                                                  348     352      +4
>boot_dow                                               -       1      +1



More information about the busybox mailing list