something looks broken :(

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Tue May 20 21:45:43 UTC 2008


On Tue, 20 May 2008, Bernhard Fischer wrote:

> On Tue, May 20, 2008 at 09:59:22PM +0200, Cristian Ionescu-Idbohrn wrote:
> ># make clean
> ># make defconfig
> ># make
> >
> >  CC      networking/tcpudp.o
> >In file included from /usr/include/linux/netfilter_ipv4.h:8,
> >                 from networking/tcpudp.c:34:
> >/usr/include/linux/netfilter.h:40: error: expected
> >specifier-qualifier-list before '__u32'
> >
> >This patch seems to help a little:
> >
> >Index: networking/tcpudp.c
> >===================================================================
> >--- networking/tcpudp.c	(revision 22001)
> >+++ networking/tcpudp.c	(working copy)
> >@@ -31,6 +31,7 @@
> >
> > #include "libbb.h"
> > /* Wants <limits.h> etc, thus included after libbb.h: */
> >+#include <linux/types.h>
> > #include <linux/netfilter_ipv4.h>
>
> No!
> This should be fixed in the kernel:
> http://repo.or.cz/w/buildroot.git?a=blob_plain;f=toolchain/kernel-headers/linux-2.6.25.4-netfilter.h-missing-include.patch

Of course.

But what is that compared to being able to build busybox _now_?
Doesn't cost much inserting that _one_ line.  And linux/types.h will not
be included again when netfilter.h is corrected, as __LINUX_NETFILTER_H
protects against that.


Cheers,

-- 
Cristian



More information about the busybox mailing list