svn commit: trunk/busybox

[Denys Vlasenko]

On Friday 16 May 2008 10:01, Bernhard Fischer wrote:
> > ifeq ($(CONFIG_WERROR),y)
> > CFLAGS += $(call cc-option,-Werror,)
> >-else
> >-# for development, warn a little bit about unused results..
> >-CPPFLAGS += -D_FORTIFY_SOURCE=2
> 
> Why did you remove fortify source? IIRC this was initially wrapped in
> CONFIG_DEBUG, fwiw.

No, it was not:

http://busybox.net/cgi-bin/viewcvs.cgi?rev=18877&view=rev

Author: 	aldot
Date: 	Thu Jun 21 03:28:11 2007 PDT (10 months, 3 weeks ago)

--- /trunk/busybox/Makefile.flags	2007/06/21 10:20:13	18876
+++ trunk/busybox/Makefile.flags	2007/06/21 10:28:11	18877
@@ -28,6 +28,9 @@
 
 ifeq ($(CONFIG_WERROR),y)
 CFLAGS += $(call cc-option,-Werror,)
+else
+# for development, warn a little bit about unused results..
+CPPFLAGS += -D_FORTIFY_SOURCE=2
 endif
 # gcc 3.x emits bogus "old style proto" warning on find.c:alloc_action()
 CFLAGS += $(call cc-ifversion, -ge, 0400, -Wold-style-definition)

I do not know what was intended, but actual patch just defined _FORTIFY_SOURCE to 2
for all non-Werror builds. This can't be right.
If you know what was meant, by all means fix it.
--
vda