LPD: working again

dronnikov at gmail.com dronnikov at gmail.com
Mon Mar 24 18:45:38 UTC 2008


Hello!

The problem of current SVN was that we overwrite subcommand s[0] while reading positive answer from client!
Fixed.
Other changes result in code shrink.

Still I think we setup environment in exec_helper() too restrictive: xsetenv IMO should be reverted back 
to putenv().

Next, I find having two sources of data filename is very bad. We should use the only one (IMO DATAFILE) and rip 
the other completely.

I tried to place comments at any of spots I have changed in patch.
Denys, please consider and comment!

--
Vladimir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lpd.patch
Type: application/octet-stream
Size: 4714 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080324/0abbe18f/attachment-0002.obj 


More information about the busybox mailing list