LPD: helper support rewritten again

Denys Vlasenko vda.linux at googlemail.com
Mon Mar 24 01:51:50 UTC 2008


On Monday 24 March 2008 00:37, Denys Vlasenko wrote:
> > So what to choose?! I have chosen to use putenv().
> > May be we should compose the whole environment "by hands"? 
> 
> Using putenv is safe.
> You should do unsetenv + free putenv'ed string.
> You, obviously, need to do it in parent, since
> you cannot do it in child (and don't need to, as exec
> blows it away anyway).
> 
> You are also leaking result of xmalloc_open_read_close().
> 
> I will apply this patch. Thanks.

I completely overlooked that we are about to run the helper
AND EXIT! We don't need to worry about leaks.
We do not need to vfork! _Just_ exec will do!

I am an idiot...

Check current svn please.
--
vda



More information about the busybox mailing list