inetd for no-MMU in trunk

Denys Vlasenko vda.linux at googlemail.com
Thu Mar 20 17:49:06 UTC 2008


On Thursday 20 March 2008 17:35, Aleksey Demakov wrote:
> Reviewing inetd in the trunk I found that the changes
> for no-MMU support IMHO go in wrong direction.
> 
> Out of the three builtins that require fork the first two
> were converted to exec an external process and the
> third was disabled altogether.
> 
> As far as I understand fork is only needed for builtins
> that work over a stream socket. For datagram sockets
> fork is never executed (in the trunk version) so there
> is no point to disable the builtin for it.
> 
> Also I think that execing a process from within a builtin
> kind of defeats the purpose of the builtin.
> 
> All in all I believe that either of these options should
> make more sense than the current approach:
> 
> 1. completely disable all builtins that require fork
> on no-MMU systems

Yes, this is a viable solutiuon - nowadays not many people
actually use "echo" and "chargen". However, it is already
implemented - just disable them in config.

> 2. disable them only to work over stream sockets and
> enable for datagram sockets.
>
> I tried to implement the second approach for 1.9.1.
> Please take a look at the attached patch.

Idea looks ok, I am interested in a patch against
the trunk.
--
vda



More information about the busybox mailing list