[rfc] macros and macro usage

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Sun Jun 15 14:48:54 UTC 2008


On Sun, 15 Jun 2008, Bernhard Fischer wrote:

> >> USE_IF_FEATURE_X and SKIP_IF_FEATURE_X would be better.
>
> I don't think explicitely adding the implied "_IF" buys anything.

True.  Costs 3 extra characters, but makes more obvious what the macro is
supposed to do.

> I disagree. There is USE_ and SKIP_ that use varargs. For bigger blocks
> or where it is more readable, there is ENABLE and !ENABLE

Not always possible (without doing more changes).  The attachment is a POC
for a ifdef free networking/udhcp/dhcpc.c (skipped indentation whitespace
for clarity).


Cheers,

-- 
Cristian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dhcpc.c.3.patch
Type: text/x-diff
Size: 1881 bytes
Desc: 
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080615/e8c4a7f7/attachment.bin 


More information about the busybox mailing list