CONFIG

[Denys Vlasenko]

On Sunday 20 July 2008 22:00, dronnikov at gmail.com wrote:
> *_for_{read,write} introduced and used. Wonder what is the size change?
> 
> Please consider applying.

-       fp = fopen("/etc/securetty", "r");
-       if (!fp) {
-               /* A missing securetty file is not an error. */
-               return 1;
-       }
-       while (fgets(buf, sizeof(buf)-1, fp)) {
-               for (i = strlen(buf)-1; i >= 0; --i) {
-                       if (!isspace(buf[i]))
+       char *buf;
+       int ret = 1;
+       parser_t *parser = config_open("/etc/securetty");

Should have used config_open2(..., fopen_for_read) here,
as it shouldn't warn.

I hope you actually tested that securetty code still works.

Size:

------------------------------------------------------------------------------
(add/remove: 5/1 grow/shrink: 8/74 up/down: 174/-737)        Total: -563 bytes
   text    data     bss     dec     hex filename
 788506     601    6696  795803   c249b busybox_old
 787943     601    6696  795240   c2268 busybox_unstripped

Good work!!!
Applied.
--
vda