CONFIG

Denys Vlasenko vda.linux at googlemail.com
Sat Jul 19 09:31:45 UTC 2008


On Saturday 19 July 2008 08:58, dronnikov at gmail.com wrote:
> Added verbose comments on config_read().
> Added testsuite (runtest parse).
> Let us collect interesting cases and thoroughly test them.
> Fixed inittab parsing. Bernhard, please test.

-	while (config_read(parser, token, -4, 0, ":", '#') >= 0) {
+ 	while (config_read(parser, token, 4, 4, "#:", PARSE_DONT_TRIM|PARSE_DONT_REDUCE|PARSE_LAST_IS_GREEDY) > 0) {

Bug. init will exit now on inittab error.

> Fixed crond.
> 
> Please comment and consider applying.

Applied with small corrections.

+config FEATURE_PARSE_COPY
+	bool "Keep a copy of current line"
+	depends on PARSE
+

Don't think it is useful; but if it is, it should be a PARSE_xxx
option, not CONFIG_xxx, so that applets which for some reason
*must* have unparsed line too, can request it.
For now there is none. You can add code for such option
and comment it out if you feel it would be needed.
Can you do this change?
--
vda



More information about the busybox mailing list