svn commit: trunk/busybox: coreutils testsuite

Denys Vlasenko vda.linux at googlemail.com
Fri Jul 18 18:46:30 UTC 2008


On Thursday 17 July 2008 11:54, Bernhard Fischer wrote:
> >--- trunk/busybox/coreutils/printf.c	2008-07-17 08:48:13 UTC (rev 22853)
> >+++ trunk/busybox/coreutils/printf.c	2008-07-17 09:17:51 UTC (rev 22854)
> >@@ -251,10 +252,12 @@
> > 				++f;
> > 				++direc_length;
> > 			}
> >-			/*
> >-			if (!strchr ("diouxXfeEgGcs", *f))
> >-			fprintf(stderr, "%%%c: invalid directive", *f);
> >-			*/
> >+			/* needed - try "printf %" without it */
> >+			if (!strchr("diouxXfeEgGcs", *f)) {
> >+				bb_error_msg("invalid directive '%s'", direc_start);
> 
> not sure if that will work out ok.
> missing 'z' (for size_t)?

Just fixed several problems with printf, added support fro %zd,
added one FIXME.

> and what about glibc's register_printf_function()?

Not applicable to printf _applet_, I think.
--
vda



More information about the busybox mailing list