[PATCH] Tidy up some missing loose ends re: cleaning.

[Robert P. J. Day]

On Fri, 18 Jul 2008, walter harms wrote:

> there is something called MRPROPER_FILES. maybe a better place ?
>
> more thinking about that there is a CLEAN_DIR and CLEAN_FILE why is there
> a find statement ? what is additonal to find ?
>
> re,
>  wh
>
>
> Robert P. J. Day wrote:
> > Add some extra files to remove for "make distclean", and add an entry
> > for mrproper to "make help".
> >
> > Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
> >
> > ---
> >
> > Index: svn/Makefile
> > ===================================================================
> > --- svn/Makefile	(revision 22872)
> > +++ svn/Makefile	(working copy)
> > @@ -983,11 +983,13 @@
> >  PHONY += distclean
> >
> >  distclean: mrproper
> > +	@rm -rf _install
> >  	@find $(srctree) $(RCS_FIND_IGNORE) \
> >  		\( -name '*.orig' -o -name '*.rej' -o -name '*~' \
> >  		-o -name '*.bak' -o -name '#*#' -o -name '.*.orig' \
> >  		-o -name '.*.rej' -o -name '*.tmp' -o -size 0 \
> > -		-o -name '*%' -o -name '.*.cmd' -o -name 'core' \) \
> > +		-o -name '*%' -o -name '.*.cmd' -o -name 'core' \
> > +		-o -name 'busybox.links' \) \
> >  		-type f -print | xargs rm -f
> >
> >
> > Index: svn/Makefile.help
> > ===================================================================
> > --- svn/Makefile.help	(revision 22872)
> > +++ svn/Makefile.help	(working copy)
> > @@ -5,6 +5,7 @@
> >  help:
> >  	@echo 'Cleaning:'
> >  	@echo '  clean			- delete temporary files created by build'
> > +	@echo '  mrproper		- delete current config, and all generated files'
> >  	@echo '  distclean		- delete all non-source files (including .config)'
> >  	@echo
> >  	@echo 'Build:'
> >
> >

(can we please not top post?)

  yes, there exists CLEAN_DIRS and CLEAN_FILES and MRPROPER_DIRS and
MRPROPER_FILES, but there is no DISTCLEAN_DIRS or DISTCLEAN_FILES, so
you can't really say that there is a hard and fast standard that
should apply here.  also, it's not clear whether those additional
objects i listed should be cleaned as part of clean, or mrproper, or
distclean.  i'm open to suggestions.

  also, you still need to do a recursive search with "find" to catch
all the temporary files that are created during a build.  if anyone
wants to restructure the cleaning, feel free.  my only point is that
there is a small list of things that are currently not being
processed which should be cleaned *somewhere*:

  _install/
  0_lib/
  busybox.links
  busybox_old       (and, yes, this should be cleaned)

  i'm not really concerned about where stuff gets cleaned, as long as
"make distclean" removes *everything* that is not part of the original
source tree.  no exceptions.  and that includes busybox_old.

rday

p.s.  here's a thought -- i'll post a new patch in which all four of
those objects above are added to either MRPROPER_DIRS or
MRPROPER_FILES, and leave the distclean target the way it is.  i think
that's the cleanest solution for now.  patch coming in a few minutes.

--


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================