some unnecessary preprocessor tests in libbb/

Robert P. J. Day rpjday at crashcourse.ca
Thu Jul 17 20:33:33 UTC 2008


On Thu, 17 Jul 2008, Denys Vlasenko wrote:

> On Thursday 17 July 2008 01:41, Robert P. J. Day wrote:
> > > >   in fact, it's misleading since it implies that the max length can be
> > > > up to almost 32K when Config.in clearly restricts the value to 8K.
> > > >
> > > > rday
> > >
> > > These checks are there simply to make sure something didn't go bad...
> > >
> > > They shouldn't add to the binary size because the compiler takes them out.
> >
> > i realize that ... i'm just a big believer in minimizing redundancy if
> > possible.  no big deal.
>
> But you are trying to reduce redundany where it almost does not
> matter - busybox binary will not get a single bit smaller.
>
> Developer resources (i.e. YOUR time) are not unlimited.
>
> I, for one, try to prioritize and avoid situations when I improve
> some tiny insignificant thingy while much bigger things need
> someone's attention. -- vda

i realize that my posts and patches are painfully trivial at the
moment, but i'm just getting back into BB so i figured i'd start
simple.  give me time, i'll get there.  :-)

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
    Have classroom, will lecture.

http://crashcourse.ca                          Waterloo, Ontario, CANADA
========================================================================



More information about the busybox mailing list