[patch] [rfc] udhcpc eating too much cpu
Cristian Ionescu-Idbohrn
cristian.ionescu-idbohrn at axis.com
Fri Jan 18 20:54:10 UTC 2008
On Fri, 18 Jan 2008, Stefan Rompf wrote:
> Am Donnerstag, 17. Januar 2008 16:49 schrieb Cristian Ionescu-Idbohrn:
>
> > (void)setsockopt(sock, SOL_SOCKET, SO_ATTACH_FILTER, &filter,
> > sizeof(filter));
> >
> > No error checking at all.
>
> Feature ;-)
I thought you'd say that ;)
> I knew some failures were ok, didn't want to distinguish and safe every
> byte. But I've taken a look at 2.6.0, it already includes BPF
> unconditionally. So I can add a check here.
Great.
> Btw, I'll also take your BPF change to check both source and destination
> port, this definitely make sense. Thanks!
Makes me happy too ;) But the credit should go to a collegue of mine
(Bcc:ed) who checked the code and suggested that.
By the way, you wodn't happen to be excited over cotributing your netlink
code (adjusted) to busybox needs?
Cheers,
--
Cristian
More information about the busybox
mailing list