[patch] [rfc] Re: udhcpc eating too much cpu

[Cristian Ionescu-Idbohrn]

Oh, Bernhard...

Why do you make my life so much more complicated than it already is ;)

On Thu, 17 Jan 2008, Bernhard Fischer wrote:

> Can you please separate the whitespace fixes from actual changes
> (diff -rdupbBw or the like to filter out the noise).

Wasn' much of that.  Attached is the result.  You could cherry pick if
you wanted to.

I made some small changes, compared to the patch I previously sent.
The BPF-filter will match on both sport and dport.  Moved some code
back into it's original position as it (curiously) saved 24 bytes.

> What is the size(1) change with your patch?

Looks like some +420 bytes.
Bigest size increase (as expected) clientsocket.o: +328 bytes.
But that's, IMO, such a small price compared to the performance
benefits :)

Here you go:

svn:
   text	   data	    bss	    dec	    hex filename
   1012	      0	      0	   1012	    3f4 arpping.o
   2668	      0	      4	   2672	    a70 clientpacket.o
    224	      0	      0	    224	     e0 clientsocket.o
      6	      0	      0	      6	      6 common.o
   5460	      4	     20	   5484	   156c dhcpc.o
   1492	      0	      0	   1492	    5d4 domain_codec.o
   1460	      0	      0	   1460	    5b4 options.o
   2116	      0	      0	   2116	    844 packet.o
   2600	      0	      0	   2600	    a28 script.o
    556	      0	      8	    564	    234 signalpipe.o
    960	      0	      0	    960	    3c0 socket.o

mine:

   text	   data	    bss	    dec	    hex filename
   1016	      0	      0	   1016	    3f8 arpping.o
   2692	      0	      4	   2696	    a88 clientpacket.o
    552	      0	      0	    552	    228 clientsocket.o
      6	      0	      0	      6	      6 common.o
   5488	      4	     20	   5512	   1588 dhcpc.o
   1492	      0	      0	   1492	    5d4 domain_codec.o
   1464	      0	      0	   1464	    5b8 options.o
   2128	      0	      0	   2128	    850 packet.o
   2604	      0	      0	   2604	    a2c script.o
    556	      0	      8	    564	    234 signalpipe.o
    976	      0	      0	    976	    3d0 socket.o


Cheers,

-- 
Cristian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bb-svn-udhcp.3.patch
Type: text/x-diff
Size: 5752 bytes
Desc: 
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080117/d488aa21/attachment-0002.bin