ps and username size

Detlef Vollmann dv at vollmann.ch
Sun Jan 6 14:12:32 UTC 2008


Denys Vlasenko wrote:

> Thanks for the report. Using %-8.8s instead of %-8s fixes this.
> 
> I am also fixing VSZ overflow with large VSZs.
> 
> Will commit changes to svn in a minute.

@@ -188,7 +188,10 @@
 static void put_lu(char *buf, int size, unsigned long u)
 {
        char buf5[5];
-       smart_ulltoa5( ((unsigned long long)u) << 10, buf5);
+
+       /* see http://en.wikipedia.org/wiki/Tera */
+       smart_ulltoa4( (u, buf5, " mgtpezy");
                      ^^
This line contains a type, leading to:
procps/ps.c: In function `put_lu':
procps/ps.c:193: warning: left-hand operand of comma expression has no effect
procps/ps.c:193: warning: left-hand operand of comma expression has no effect
procps/ps.c:193: parse error before ';' token

  Detlef

-- 
Detlef Vollmann   vollmann engineering gmbh
Linux and C++ for Embedded Systems    http://www.vollmann.ch/



More information about the busybox mailing list