[patch] - new bbsplash applet

Bernhard Fischer rep.dot.nop at gmail.com
Mon Feb 11 16:59:50 UTC 2008


On Mon, Feb 11, 2008 at 05:18:03PM +0100, Michele Sanges wrote:
>Hello Bernhard,
>
>thanks for your comments.
>Following your indication i changed the code but ...
>
>Il giorno ven, 08/02/2008 alle 14.28 +0100, Bernhard Fischer ha
>scritto: 
>> >+		// parameter	
>> >+		memcpy(strParam, strIniRecord, nPos);
>> >+		strParam[nPos] = '\0';
>> >+		// value		
>> >+		pValue[strlen(pValue)-1] = '\0';
>> >+		
>> >+		if (strcmp(strParam, "DEBUG_MESSAGES") == 0)
>> 
>> erm, no. Use index_in_str_array() or try to reuse mdev's config parser
>> for this..
>
>... can you tell me what's wrong? index_in_str_array() use strcmp too.

Change it and look at the size before and after this change to see what
i mean.

cheers,
Bernhard



More information about the busybox mailing list