variable assignment / command substitution

Denys Vlasenko vda.linux at googlemail.com
Mon Feb 11 08:34:02 UTC 2008


On Sunday 10 February 2008 20:57, Martinb_ARM_NOMMU_KISSDVD wrote:
> Thanks, fix is working for me
> 
> Did some testing and my (old) scripts still work :)
> 
> I still do have one suggestion about the platform.h
> 
> I would suggest to change the comment about the EXTRA_CFLAGS="-DBB_NOMMU"
> Or implement the flag (now its confusing)
> 
> I also did made one small modification but I don’t want to call this a patch
> because its possible its a bug on something else
> 
> If I do a:
> 
> ls -l /proc/*/fd/
> 
> Then I see some files descriptors holding some files open
> in my case I cant dismount my /hdd anymore so for me this is a problem
> 
> the way to prevent this is to insert the following line inside the hush.c
> 
>     if (argv[optind] == NULL) {
>         opt = parse_and_run_file(stdin);
>     } else {
>         debug_printf("\nrunning script '%s'\n", argv[optind]);
>         global_argv = argv + optind;
>         global_argc = argc - optind;
>         input = xfopen(argv[optind], "r");
>         fcntl(fileno(input), F_SETFD,FD_CLOEXEC);		<<<<<<<<<<<<<<<<<<< this
> line I did insert
>         opt = parse_and_run_file(input);
>     }

Applied, thanks.
--
vda



More information about the busybox mailing list