[patch] networking/ping.c

Cristian Ionescu-Idbohrn cristian.ionescu-idbohrn at axis.com
Fri Feb 1 23:05:03 UTC 2008


On Wed, 30 Jan 2008, Cristian Ionescu-Idbohrn wrote:

> Looks like last checkin with this comment:
>
> ,----
> | r20923 | aldot | 2008-01-29 11:33:34 +0100 (Tue, 29 Jan 2008) | 4 lines
> | - be C99 friendly. Anonymous unions are a GNU extension. This change is
> |   size-neutral WRT -std=gnu99 and fixes several compilation errors for
> |   strict C99 mode.
> `----
>
> missed a couple of spots.  Compilation error:

Ok.  No reaction, yet.  Let me try again.

If I disable FEATURE_FANCY_PING (which is enabled by default) and then try
to build, I get this thrown at me:

,----
| networking/ping.c: In function 'ping4':
| networking/ping.c:97: error: 'len_and_sockaddr' has no member named 'sin'
| networking/ping.c: In function 'ping6':
| networking/ping.c:141: error: 'len_and_sockaddr' has no member named 'sin6'
| make[1]: *** [networking/ping.o] Error 1
`----

The attached patch corrects that.  It also reorders networking/Config.in
moving FEATURE_FANCY_PING next to PING6.


Cheers,

-- 
Cristian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ping-and-Config.patch
Type: text/x-diff
Size: 1361 bytes
Desc: 
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080202/4a8bb466/attachment-0002.bin 


More information about the busybox mailing list