[PATCH] fsck -A goes into infinite loop and kills all processes

Roy Marples roy at marples.name
Fri Feb 1 11:46:11 UTC 2008


On Thu, 2008-01-31 at 20:32 +0000, Roy Marples wrote:
> On Thu, 2008-01-31 at 18:17 +0000, Roy Marples wrote:
> > Ah yes, it's because there is no helper installed for ext4dev. Ensuring
> > that all helpers exist fixes the error. So it's not handling exec errors
> > correctly. I'll see if I can fix fsck now.
> 
> The execute function does not return when pid is <1, so it stores -1 as
> a pid to kill, which kills quite a bit really :)

Attached is a new patch that free's any malloced memory correctly. BTW,
this behaviour should match upstream as if the don't find a helper then
they free the instance and return even if noexecute is set. As the spawn
function does that as well, we just need to check if pid is less than 1.

Thanks

Roy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: busybox-fsck.patch
Type: text/x-patch
Size: 469 bytes
Desc: not available
Url : http://lists.busybox.net/pipermail/busybox/attachments/20080201/463d921e/attachment-0002.bin 


More information about the busybox mailing list