[PATCH] wget: add timeout parameter

Bernhard Reutner-Fischer rep.dot.nop at gmail.com
Tue Aug 19 14:26:26 UTC 2008


On Tue, Aug 19, 2008 at 03:58:12PM +0200, Matthias Kaehlcke wrote:
>Hi Bernhard,
>
>El Tue, Aug 19, 2008 at 01:57:13PM +0200 Bernhard Reutner-Fischer ha dit:
>
>> ...
>>
>> Care to resend?
>
>thanks for your review and your constructive comments. here is a new
>version of the patch that adresses the issues you brought up.
>
>> PS: a size(1) would have been nice
>
>what does size(1) mean? a patch with zero impact on the size of the
>binary? if desired i can add a config option for the timeout
>parameter

I ment the size output from before and after your patch. Ideally every
patch would reduce the total size, regardless whether the patch adds or
removes a feature, but that's of course not (always) possible. I don't
think a config option for the timeout makes sense.

Thanks for the updated patch, i'll test and apply it soon (unless
somebody beats me to it).
If you experience size-increase with using "quiet" instead of looking at
opt (i didn't try), then please follow-up.

cheers,



More information about the busybox mailing list