just another one of my rumblings

Denys Vlasenko vda.linux at googlemail.com
Fri Apr 25 23:11:24 UTC 2008


On Friday 25 April 2008 21:37, Cristian Ionescu-Idbohrn wrote:
> 
> Ok.  I've sinned :(
> 
> 	mkdir -p ".tmpdir.$applet" || :
> 
> then?
> 
> > I want to also ask you to generally avoid changes
> > which don't really change anything, like this one:
> >
> > -       d="$tsdir" sh -x -e "$testcase" >"$testname.stdout.txt" 2>&1
> > +       d="$tsdir" sh -x -e "$testcase" > "$testname.stdout.txt" 2>&1
> 
> Alright.  Point taken.

If you want to try submitting that patch again, split it into 2-3 patches,
and put the least controversial changes (aka "fixes a real bug")
in the first one, cleanups in second, and so on.
--
vda




More information about the busybox mailing list